rust-tui: Update Ditto SDK to 4.10.2 and Use Rust 1.81.0#67
rust-tui: Update Ditto SDK to 4.10.2 and Use Rust 1.81.0#67Kristopher Johnson (kristopherjohnson) wants to merge 7 commits intomainfrom
Conversation
Kristopher Johnson (kristopherjohnson)
marked this pull request as ready for review
Kristopher Johnson (kristopherjohnson)
requested review from
a team and
Cameron Mcloughlin (cameron1024)
as code owners
Kristopher Johnson (kristopherjohnson)
changed the title
Vincent Ahrend (pvditto)
left a comment
Vincent Ahrend (pvditto)
left a comment
There was a problem hiding this comment.
LGTM, some comments below.
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| toolchain: 1.81.0 |
There was a problem hiding this comment.
Is it possible to source this from the rust-toolchain file to avoid a duplicate source of truth?
There was a problem hiding this comment.
Add this step before this "Install Rust" step:
- name: Set RUST_VERSION
run: echo "RUST_VERSION=$(cat rust-toolchain)" >> $GITHUB_ENV| toolchain: 1.81.0 | |
| toolchain: ${{ env.RUST_VERSION }} |
| @@ -0,0 +1,6 @@ | |||
| fn main() { | |||
| // Workaround for "multiple definition" linker errors on Linux (#SDKS-1088) | |||
There was a problem hiding this comment.
Is this fix just needed for our specific CI setup or something that customers should understand how to apply to their own setups? A bit more context could help when someone is reading this code who is not familiar with this issue.
| tracing-subscriber = { version = "0.3.19", features = ["env-filter"] } | ||
| tokio-stream = { version = "0.1.17", features = ["sync"] } | ||
| uuid = "1.13" | ||
|
|
There was a problem hiding this comment.
Is this removal of a trailing new line intentional?
|
This might need to get closed given we have a PR now for 4.11.1. |
|
Closing this, as it is superseded by updates for the v5 SDK |
4 participants
Updates the Rust SDK version to 4.10.2, and works around linker errors when building on Ubuntu.
This also updates the GitHub actions to use Rust 1.81.0 in CI, which is the version needed for compatibility with the 4.10.2 SDK.
Closes SDKS-1088